Update to embedded-hal 1.0.
#16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reitermarkus
force-pushed
the
embedded-hal-1
branch
6 times, most recently
from
3cd5be3 to
fa3ca00
Compare
reitermarkus
changed the title
embedded-hal 1.0.embedded-hal 1.0.
reitermarkus
force-pushed
the
embedded-hal-1
branch
6 times, most recently
from
95b813a to
1d22965
Compare
eldruin
reviewed
Jan 17, 2024
reitermarkus
force-pushed
the
embedded-hal-1
branch
2 times, most recently
from
56fecb6 to
5f797bc
Compare
|
@eldruin, I moved the additional changes to a separate PR. This one should be manageable now. |
eldruin
requested changes
Jan 18, 2024
There was a problem hiding this comment.
This still changes many things on top of updating to e-h 1.0.
- Please do not remove
DynamicOneShot. It is a useful trait asked for by the community. - Why did you remove the whole device-specific channel selection mechanism? That ensures that only valid channels for the current device can be read.
From reading #10 (comment), it looks like this trait didn't actually solve the issue, which is why I removed it.
Ah, I missed that this ensures only valid channels. I simply removed it since there is no corresponding |
reitermarkus
force-pushed
the
embedded-hal-1
branch
from
b58cc94 to
6c12cc8
Compare
|
@eldruin, I have now re-added the device-specific channel selection. |
eldruin
reviewed
Jan 18, 2024
reitermarkus
force-pushed
the
embedded-hal-1
branch
2 times, most recently
from
156564d to
389d5bc
Compare
This was referenced Jan 18, 2024
Merged
reitermarkus
force-pushed
the
embedded-hal-1
branch
2 times, most recently
from
e52dd96 to
d809bfc
Compare
eldruin
reviewed
Jan 18, 2024
reitermarkus
force-pushed
the
embedded-hal-1
branch
from
d809bfc to
e6cc9d7
Compare
reitermarkus
force-pushed
the
embedded-hal-1
branch
from
e6cc9d7 to
904325d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.